-
Notifications
You must be signed in to change notification settings - Fork 409
Update .NET SDK, PowerShell SDK, Newtonsoft.Json and codeowners #2143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates three key dependencies that require manual updates due to Dependabot configuration: the .NET SDK version, the PowerShell SDK (System.Management.Automation), and the Newtonsoft.Json library.
- Updated .NET SDK from 8.0.406 to 8.0.416
- Updated System.Management.Automation package and minimum PowerShell Core version from 7.4.7 to 7.4.13
- Updated Newtonsoft.Json from 13.0.3 to 13.0.4
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| global.json | Updates .NET SDK version from 8.0.406 to 8.0.416 |
| Engine/PSScriptAnalyzer.psm1 | Updates minimum PowerShell Core version requirement to 7.4.13, maintaining sync with System.Management.Automation package |
| Directory.Packages.props | Updates System.Management.Automation package to 7.4.13 and Newtonsoft.Json to 13.0.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Otherwise we're stuck unable to merge.
bergmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for Newtonsoft.Json, minimum version is the one used by oldest supported version of PowerShell, which is now 7.4.13, which now uses Newtonsoft 13.0.4 now so that change is fine: https://github.com/PowerShell/PowerShell/blob/5a6ecbf8c98d6d6193c3dcbed75d3454adbbfd09/src/System.Management.Automation/System.Management.Automation.csproj#L31
Update for minimum PS version patch fine as well.
.NET SDK is not as tightly coupled, I think the major version just cannot be newer than the one used by oldest supported PS version. PS used 8.0.415 but it shouldn't be a problem using a newer patch version since PSSA is not self-contained and always relies on PowerShell's engine for execution of its code: https://github.com/PowerShell/PowerShell/blob/v7.4.13/global.json
I am getting this error when hovering over new code owner but I trust you have tested this new kind of referencing:

|
Thanks for checking @bergmeister
👍
👍
Internal release systems were requiring us to update this. To be honest, bug's in their end. The pipeline is supposed to build with
Yeah, it exists, and it should be public, but it seems like GitHub and Microsoft's SSO integration is breaking that for you. My guess is you can't view https://github.com/orgs/PowerShell/teams/extension
|
|
I missed the Directory.Build.props file, oops. Part of me wants to delete the Codeowners file because it has gone from a useful "ping these people" tool to a broken "require reviews from these people" that I can no longer override, even when I really need to and I have elevated myself to administrator. |


Oh Dependabot, where art thou?